Send the Patch to Andrew Leary, I think he still maintains the
distributed sources.
I did that before even posting about it here. ;)
Maybe your patch should have its own parameter to activate, so it
will
not change the the output currently produced by -t.
Maybe. That's up to the maintainer, I suppose.
IMO, I don't really see enough reason to make a new parameter, though, unless it would be an option or extension to '-t' for 'verbose', or something in those lines. It basically does the exact same thing it
did, just outputs more information in test mode. Rather than "there is
an error..." the patch makes it "there is an error, and this is what
it is ..."
Just as well, it doesn't need to be changed at all, really. If that
was the original way it was intended, so be it. I didn't understand
why it wouldn't tell you what the actual error was, so I made it do
so.
If people already have their own workarounds in place (ie. running it
in process mode instead of even using test mode, or using a script of
some sort to verify what the error actually is), then let it be. ;)
When I get a few minutes to look at it further, I want to look at a
few things in MakeNL anyway. There was a proposal years ago to add password protection to nodelist segment submissions; I've been
thinking about actually implementing something along those lines. Currently there is no check on the origin of a submitted segment file;
if it has the correct filename and arrives in the coordinator's
inbound, it will be imported.
I did get your email about this; it's on my list of things to get to soon(ish).
We already have something for that: the TIC system. When I was RC28 I used to send my segments to Ward accompanied by a .TIC file. So his file manager
could move it from the secure inbound to the proper directory for safe processing.
On 05 Oct 26 19:18:04, Mark Lewis said the following to Michiel Van Der Vlist:
that made me blink a few times... i don't know that i've ever heard of
anyo using tic/raid/hatch/etc to send nodelist segments upstream... i
can imagin some script and settings work is needed to prevent makenl
and similar from using the normal file attached netmail method and to
do all the things need for hatching the file upstream...
Thats how it works amongst ZC's.
When I get a few minutes to look at it further, I want to look at a few things in MakeNL anyway. There was a proposal years ago to add password protection to nodelist segment submissions; I've been thinking about actually implementing something along those lines. Currently there is no check on the origin of a submitted segment file; if it has the correct filename and arrives in the coordinator's inbound, it will be imported.
If a troublemaker discovers the segment filename used, they could potentially submit a modified segment file to add bogus nodelist entries, delete valid nodes, change the coordinator of a net or region, etc. I
admit it's unlikely these days, but it could happen.
implementing something along those lines. Currently there is no
check on t origin of a submitted segment file; if it has the
correct filename and arri in the coordinator's inbound, it will be
imported. If a troublemaker
Then the Coordinator is imcompetent.
Segments are received via secure BinkD sessions already password protected. If a file is received via unsecure means, it is moved to a directory here for manual inspection.
We already have something for that: the TIC system. When I was RC28 I
used to send my segments to Ward accompanied by a .TIC file. So his
file manager could move it from the secure inbound to the proper
directory for safe processing.
that made me blink a few times... i don't know that i've ever heard of anyone using tic/raid/hatch/etc to send nodelist segments upstream...
i can imagine some script and settings work is needed to prevent
makenl and similar from using the normal file attached netmail method
and to do all the things needed for hatching the file upstream...
When I get a few minutes to look at it further, I want to look at
a few things in MakeNL anyway. There was a proposal years ago to
add password protection to nodelist segment submissions; I've been
thinking about actually implementing something along those lines.
Currently there is no check on the origin of a submitted segment
file; if it has the correct filename and arrives in the
coordinator's inbound, it will be imported. If a troublemaker
discovers the segment filename used, they could potentially submit
a modified segment file to add bogus nodelist entries, delete
valid nodes, change the coordinator of a net or region, etc. I
admit it's unlikely these days, but it could happen.
My take on this:
1) It has been attempted in the 1990-ies, never worked. People have
also sent
in bogus Fidonews-articlea mind you
2) Sessions are password protected. Try to send a bogus segment and:
a} it will be discovered
b} the node attempting this, is a goner
c} Don't you love things like the DAILY-nodelists? They can be
re-issued daily to recover damage
3) I became ZC for the first time in October 1994. 1666 nodelists
later I
don't see the use
4) Everybody in life is entitled to some fun, so if you want to
develop
something like this, go ahead. No-one will use it. Top-level *Cs
are
already happy there's someone willing/available to do the job.
5) If it ain't broke, don't fix it.
6) The correct file-names for the REGION-files for both Z1 and Z2 are
published daily. It's no secret.
Yes, the secure inbound is a good first step. However, in most cases there no way to tell which of your secure links sent a file, other than going through your mailer log files.
We already have something for that: the TIC system. When I was
RC28 I used to send my segments to Ward accompanied by a .TIC
file. So his file manager could move it from the secure inbound
to the proper directory for safe processing.
This is probably the easiest way to do it. This would enable
validation of the node sending the file, along with checking the .TIC
file password and the file CRC.
that made me blink a few times... i don't know that i've ever
heard of anyone using tic/raid/hatch/etc to send nodelist
segments upstream... i can imagine some script and settings work
is needed to prevent makenl and similar from using the normal
file attached netmail method and to do all the things needed for
hatching the file upstream...
All that would really be required in the case of MakeNL is commenting
out the SUBMIT entry in the control file. Then the coordinator would
need to use some means of detecting that a new segment was created
(such as the return code from MakeNL), and then hatch the file in the correct file echo.
Segments are received via secure BinkD sessions already password
protected. If a file is received via unsecure means, it is moved
to a directory here for manual inspection.
Yes, the secure inbound is a good first step. However, in most cases there is no way to tell which of your secure links sent a file, other
than going through your mailer log files.
I never understood the mindset of the folks that used to create mail bombs, either. That doesn't mean that we shouldn't attempt to secure things.
If someone running the latest makenl can verify my findings, I would appreciate it:
https://github.com/zoomosis/makenl/issues/7
Steps to reproduce:
1) Purposely cause an error in one of your segments
2) Copy it to /received (or the "new" process directory) and/or keep a copy of
it in the master directory (ie. try both). 3) Run "makenl <control file> -t"
for "test mode". 4) Don't forget to revert any changes back to normal after
testing.
In my test cases, no errors were found at all using the "test" mode (I had multiple errors that were there for months, and I don't paste my logs for my
'othernet' like I do for Fidonet, so it went unnoticed). It wasn't until processing manually where I noticed the problems, after being notified that
something was wrong.
For the AmigaNet nodelist I found out a long time ago the test mode is useless. For "testing" I just generate the nodelist for real (but don't hatch it of course)...
Hey All!
If someone running the latest makenl can verify my findings, I would appreciate it:
https://github.com/zoomosis/makenl/issues/7
Steps to reproduce:
1) Purposely cause an error in one of your segments
2) Copy it to /received (or the "new" process directory) and/or keep a
copy of it in the master directory (ie. try both). 3) Run "makenl
<control file> -t" for "test mode". 4) Don't forget to revert any
changes back to normal after testing.
In my test cases, no errors were found at all using the "test" mode (I
had multiple errors that were there for months, and I don't paste my
logs for my 'othernet' like I do for Fidonet, so it went unnoticed).
It wasn't until processing manually where I noticed the problems,
after being notified that something was wrong.
Surprisingly, it didn't take long for chatgpt to indicate `"-t" sets mustbenew = 1, so openlist() doesn't even search UpdateDir or
MasterDir.`
I seem to have an easy fix in procfile.c (line 99), tested during this previous weekly run that nothing else was affected, and test mode now
works as expected:
```
- if (ShouldProcess == 0 && MergeOutFILE == 0) /* Process only
+ if (ShouldProcess == 0 && !JustTest && MergeOutFILE == 0) /* Process
only
new
files */
mustbenew = 1;Else
mustbenew = 0;
```
Regards,
Nick
... Sarcasm, because beating people up is illegal.
For the AmigaNet nodelist I found out a long time ago the test mode
is useless. For "testing" I just generate the nodelist for real (but
don't hatch it of course)...
Did you ever report it?
Did you try my fix?
You are using a very old and unsupported version.
The one I use under Linux is v3.5.1 dated March 2025.
and no I do not assume it is bug free.
No, I didn't realise it could be a bug. Just thought I didn't really understood the test feature or what it was supposed to do. And I found a sollution by not using it, so there was no need to put more time into it. ;-)
No, I didn't realise it could be a bug. Just thought I didn't really
understood the test feature or what it was supposed to do. And I found
a sollution by not using it, so there was no need to put more time
into it. ;-)
I guess my assumption was always that it should do exactly what "-p" (process mode) does, except don't hatch out new files.
After production the return code shoud be less than 2
In the way you use makenl -t may have no visible results, but the test
mode does have a function when you import segments from others.
Do not remove it.
When running from the command line, I wasn't getting any visible results. The patch I applied seems to have fixed that.
When running from the command line, I wasn't getting any visible
results. The patch I applied seems to have fixed that.
Did you set "loglevel x" in the controlfile? I use "1".
* Keep in mind I've kept one timestamp from the original snippets on the very first line and removed the rest, and got rid of a couple extra spaces to format these snippets to fit in an 80 character terminal.
When I ran a test with an error in "agn1.txt" in the 'master' directory (I completely removed one 'sysop_name' field of one entry), the logs showed this:
- 25-Sep-2026 18:35:31 makenl[1319142]
MakeNL 3.5.1 (Linux) compiled with GNU C on Mar 8 2024 06:29:24
MakeNL started
Cmdline: ./makenl "agoranet.ctl" "-T"
Using 'agoranet.ctl' in '/home/fido/makenl'
Begin processing 'agoranet' -- 18:35, Friday, September 25, 2026 Processing Network 1 -- file '/home/fido/makenl/agoranet/agn1.txt' Processing Network 10 -- file '/home/fido/makenl/agoranet/agn10.261' Processing Network 2 -- file '/home/fido/makenl/agoranet/agn2.txt' Processing Network 20 -- file '/home/fido/makenl/agoranet/agn20.261' Processing Network 3 -- file '/home/fido/makenl/agoranet/agn3.txt' Processing Network 30 -- file '/home/fido/makenl/agoranet/agn30.261' CRC = 00000
MakeNL finished (rc=3)
Then, I copied that segment to the 'update' directory:
- 25-Sep-2026 18:37:33 makenl[1319347]
MakeNL 3.5.1 (Linux) compiled with GNU C on Mar 8 2024 06:29:24
MakeNL started
Cmdline: ./makenl "agoranet.ctl" "-T"
Using 'agoranet.ctl' in '/home/fido/makenl'
Begin processing 'agoranet' -- 18:37, Friday, September 25, 2026 Processing Network 1 -- file '/home/fido/makenl/agoranet/received/agn1.txt' Processing Network 10 -- file '/home/fido/makenl/agoranet/agn10.261' Processing Network 2 -- file '/home/fido/makenl/agoranet/agn2.txt' Processing Network 20 -- file '/home/fido/makenl/agoranet/agn20.261' Processing Network 3 -- file '/home/fido/makenl/agoranet/agn3.txt' Processing Network 30 -- file '/home/fido/makenl/agoranet/agn30.261' CRC = 00000 MakeNL finished (rc=3)
Then, after I applied the minor change to procfile.c, it finally
caught
the
error:
- 25-Sep-2026 18:40:21 makenl[1319641]
MakeNL 3.5.2 (Linux) compiled with GNU C on Sep 25 2026 18:39:34
MakeNL started
Cmdline: ./makenl "agoranet.ctl" "-T"
makenl[1319641] Using 'agoranet.ctl' in '/home/fido/makenl'
Begin processing 'agoranet' -- 18:40, Friday, September 25, 2026 Processing Network 1 -- file '/home/fido/makenl/agoranet/received/agn1.txt' ,100,The_Pharcyde_HUB,Pewauk ee_WI,-Unpublished-,300,CM,INA:binkp.pharcyde.org,IBN agn1.txt -- Invalid baud rate -- 'CM' Processing Network 10 -- file '/home/fido/makenl/agoranet/agn10.261' Processing Network 2 -- file '/home/fido/makenl/agoranet/agn2.txt' Processing Network 20 -- file '/home/fido/makenl/agoranet/agn20.261' Processing Network 3 -- file '/home/fido/makenl/agoranet/agn3.txt' Processing Network 30 -- file '/home/fido/makenl/agoranet/agn30.261' CRC = 00000 MakeNL finished (rc=4)
"-p" or 'process mode' is unchanged/unaffected, as far as I can tell.
Hey Vincent!
On Thu, Oct 01 2026 14:34:00 +0100, you wrote:
You are using a very old and unsupported version.
Are you even paying attention?
The one I use under Linux is v3.5.1 dated March 2025.
I'm using the exact same one. That's why I said "the latest makenl"
and gave the link to the source.
and no I do not assume it is bug free.
Thanks for your input.
Cmdline: ./makenl "agoranet.ctl" "-T"
I am not shure if it like the capital T. It to late to try now 00:30 AM
MakeNL finished (rc=3)
It gives a return code 3, that indicates an error
Then, I copied that segment to the 'update' directory:
You can see no nodelist is produces as de CRC = 00000
the rc does not look right to me as I beleice 4 is the lowest for -t
Then, after I applied the minor change to procfile.c, it finally caught
the error:
Here the rc = 4 is different, the logfiles only mention the files
used.
As for where incoming en tested files should go is in de config file.
Your new files goes into incoming, -t moves it to update and there is
I am getting a bit dense, I will be more coherent in daytime.
No, you asked if any one was and did not specify the version you are, using.
Hey Vincent!
On Fri, Oct 02 2026 00:23:38 +0100, you wrote:
No, you asked if any one was and did not specify the version you
are, using.
Why would I create an issue on github (and link to it) where the
latest sources reside if I wasn't running the latest sources? I didn't
want a response from anyone using an older version, which is why I
asked for people that were on the latest sources (as I am).
This is only in the logfile. I actually ran it with a lowercase 't'. You can run it either way, though.
MakeNL finished (rc=3)
It gives a return code 3, that indicates an error
That's not enough for me, then (also, I didn't know that).
I wanted the
error actually written out. I went years with errors in my segment
because
test mode wasn't actually telling me the line the error was on, whereas process mode was (and I wasn't looking at it, because I had assumed there were no errors because test mode wasn't telling me clear enough).
Here the rc = 4 is different, the logfiles only mention the files
used.
I suppose I was unsure as to anything 'rc' meant.
You are again "assuming".
I am not aware of the specifity you want in the error reporting of
makenl.
I cannot help you there.
I wasn't asking for your help. Instead, I was asking for verification that others using the latest sources weren't seeing what the error actually was.
I made it do what I wanted it to do (It now reports /what/ the error
is
while in test mode (-t) - much like process mode does, not just that there /is/ an error specified with an exit code), and announcing the patch here if anyone wants to use it.
Send the Patch to Andrew Leary, I think he still maintains the
distributed sources.
Maybe your patch should have its own parameter to activate, so it will
not change the the output currently produced by -t.
| Sysop: | altere |
|---|---|
| Location: | Houston, TX |
| Users: | 76 |
| Nodes: | 4 (0 / 4) |
| Uptime: | 02:03:18 |
| Calls: | 2,190 |
| Files: | 9,564 |
| Messages: | 323,293 |